Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Platform: add a custom logger class (maybe @openfn/logger) #128

Open
josephjclark opened this issue Dec 3, 2024 · 0 comments
Open

Platform: add a custom logger class (maybe @openfn/logger) #128

josephjclark opened this issue Dec 3, 2024 · 0 comments

Comments

@josephjclark
Copy link
Collaborator

We should add a custom logger class to the main server platform

Instead of doing console.log(), we should use logger.log()

Advantages of this are:

  • prettier output
  • ability to test log output in unit tests
  • ability to suppress out output in unit tests

Just like we do with @openfn/logger.

We could actually just use @openfn/logger 🤔 That way Apollo will feel like other OpenFn CLI tools, and we have predictable debug capabilities.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@josephjclark