Collections: should get return an object or an array?

[josephjclark]

When I do collections.get('collection', '*'), the returned state.data is an array of {key, value} pairs. The array has a cursor key.

Maybe I've just confused myself after doing the CLI, but shouldn't we return an object of keys and values? Ie, { key1: { ... },key2: { ...} }

We'd probably have to nest it in an { items, cursor } object to expose the cursor to the user.

Some considerations:

• The CLI will output and object of key/value pairs. Surely the adaptor and CLI should use the same structure?
• each will call the callback with state, value, key. No object.
• If I return an object, that's a bit harder to iterate over. I can't do state.data.map(({value}) => { ... }). I probably can't pass it into common.each.
• the {key, value } structure allows us to return metadata, like created and udpated timestamps, ie {key, value, created, updated }. This was actually the initial design and is what the wire format should look like. If we don't use this structure, how do we handle metadata? If we return a flat object there's no space. We'd have to add a non-iteratable meta key or something

Hmm. Maybe we're doing the right thing with the array. I'll think about this overnight.