Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do we really have to commit ast.json? #841

Open
josephjclark opened this issue Nov 28, 2024 · 0 comments
Open

Do we really have to commit ast.json? #841

josephjclark opened this issue Nov 28, 2024 · 0 comments

Comments

@josephjclark
Copy link
Collaborator

I'm forever forgetting to commit ast.json into the repo (and I'm not the only one). It's a really annoying hidden dependency we have which blocks releases.

Do we really need to to be checked in?

I know the docs build needs it but it could build the ASTs itself. We've got a very complex docs build now and my instinct is we could remove the commited artefacts from maim.

We could even explore auto-commiting the AST in the public step.

Requires more investigation

@github-project-automation github-project-automation bot moved this to New Issues in v2 Nov 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: New Issues
Development

No branches or pull requests

1 participant