Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Documentation mistake? #582

Open
groshevdg opened this issue Aug 26, 2024 · 1 comment
Open

Documentation mistake? #582

groshevdg opened this issue Aug 26, 2024 · 1 comment

Comments

@groshevdg
Copy link

groshevdg commented Aug 26, 2024

Hi there. Thank you for this package. It's really useful one.
I've got a question related to the documentation. There is a mention in the docs that widget won't be marked as one that needs rebuild if:

  • Widget does not declare SU mixin
  • responsiveWidgets does not contains widget name

But I've checked code and noticed that widget marks dirty if widget is SU or responsiveWidgets.contains(widgetName).

 final allowed = widget is SU ||
        _canMarkedToBuild.contains(widgetName) ||
        !(widgetName.startsWith('_') || flutterWidgets.contains(widgetName));

    if (allowed) el.markNeedsBuild();

Is that a mistake in the docs or I got something wrong?

Thank you in advance!

@m-spiridon
Copy link

I've also found the updated docs confusing

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants
@groshevdg @m-spiridon and others