Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

The latest code in master had issues with opening queries #29

Open
kkrumlian opened this issue Oct 18, 2023 · 2 comments
Open

The latest code in master had issues with opening queries #29

kkrumlian opened this issue Oct 18, 2023 · 2 comments
Assignees
@MartijnR
Labels
ready-for-final-review
Milestone
Next

Comments

@kkrumlian
Copy link

We are not able to create queries
screen_shot_2023-10-13_at_12 43 17_pm
@MartijnR
Copy link
Member

MartijnR commented Oct 18, 2023 •
edited
Loading

reproduce with: http://localhost:8005/single/fs/i/x3Rsw83W?ecid=1

  • add failing test
  • fix

There is a test but it looks at a form instance instead of the Form prototype (constraintClassesInvalid).

@pbowen-oc pbowen-oc added this to the Next milestone Oct 18, 2023
@MartijnR
Copy link
Member

MartijnR commented Oct 18, 2023 •
edited
Loading

Fix is complete but I'll wait until after OpenClinica/enketo-express-oc#707, to avoid merge issues.

(Form.prototype.constraintClassesInvalid in dn-widget.js in stash fix-707)

@MartijnR MartijnR mentioned this issue Oct 19, 2023
Merged
@MartijnR MartijnR transferred this issue from OpenClinica/enketo-express-oc May 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@MartijnR MartijnR

Labels
ready-for-final-review
Projects
None yet
Milestone
Next
Development

No branches or pull requests
3 participants
@MartijnR @kkrumlian @pbowen-oc