Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change Adapter::write_request interface #303

Open
spikeyamk opened this issue May 3, 2024 · 1 comment
Open

Change Adapter::write_request interface #303

spikeyamk opened this issue May 3, 2024 · 1 comment
Labels
enhancement New feature or request

Comments

@spikeyamk
Copy link

spikeyamk commented May 3, 2024

Hello current function signature is this:

bool write_request(BluetoothUUID const& service, BluetoothUUID const& characteristic, ByteArray const& data) noexcept;

Could this be changed to

bool write_request(Service const& service, Characteristic const& characteristic, ByteArray const& data) noexcept;

I spent a long time today troubleshooting because I put the service and characteristic argument backwards. The strong type system is something you can rely on.

@kdewald
Copy link
Member

kdewald commented May 4, 2024

Hey! This is not a bad idea! This requires a bit of care to ensure we don't break all existing use cases, but I'll definitely take it into consideration.

@kdewald kdewald added the enhancement New feature or request label May 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants