-
-
Notifications
You must be signed in to change notification settings - Fork 106
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Characteristic read on MacOS broken since #255 #277
Comments
i can confirm that commit
|
I believe this issue is still present in the |
Yes, you'll notice in the changelog that no new fixes have been added since prior to the license change. The goal right now is to get that right to ensure there is actually a viable path towards growing SimpleBLE sustainably. |
Same in the |
@kdewald does that mean you don't want a fix? |
Hey! Just to keep everybody here posted on the latest updates: The transition to a commercial license is coming along better than anticipated, which in turn means that we have a lot more work ahead of us. Our company incorporation is underway, legal docs are being reviewed and the team is also starting to grow, with Pedro Dans being our first addition and a few others in the pipeline (yay!). Development is still ongoing, in particular focused on getting Android support of the ground. This would go faster if it weren't for some very poor API decisions on Google's end, so I'll need everybody to stay patient for a bit longer until my pathfinder implementation is ready, which is when I'll be able to start delegating tasks and focus on fixing these lingering bugs. This process will get better, right now we're transitioning from almost nonexistent work to growing pains in the span of a few weeks, but I can promise that the end result will be a kickass library everybody will be able to enjoy. |
Okay, after carving out some time I can at least say that I was able to replicate the bug locally, which means it will definitely be fixed for the 0.8 release. On some other notes: Company is incorporated, commercial license is ready and we're currently in the process of onboarding customers, so things have been excitedly busy. @Symbitic @thegecko, as a reminder, we want to make sure you can use SimpleBLE for webbluetooth and thus want to provide the license to you for free, no strings attached. |
Will the license allow any commercial users of |
@thegecko Strong yes! We've spent a lot of time (and money) on our legal reviews to make sure this use case is supported. The TL;DR is that SimpleBLE can be bundled as part of MIT/Apache licensed projects by adding a notice to users that the bundled version of SimpleBLE can only be used as part of that downstream project and can't be extracted to use on other things. Some of our customers are building MIT-licensed libraries (which include SimpleBLE for BLE support) for their products, and this approach is working for them. |
The notify crash seems to be caused by |
Hey all! The fix for this issue is up in #326 We're moving as fast as we can :P |
Also, thanks a lot to @TellowKrinkle for that hint. It made the solution very fast to find. |
The rewrite in #255 has introduced a bug where characteristic reads on MacOS are no longer working.
This was detected when running tests after a SimpleBLE update in thegecko/webbluetooth#131
I've had a dig about, but I'm not an ObjectiveC expert. I think there are two problems:
synchronized
s here somehow block the didUpdateValueForCharacteristic delegate callback from runningNO
and there is no wait for the characteristic to be read hereAny ideas @kdewald ?
The text was updated successfully, but these errors were encountered: