Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: new regex filter feature #2457

Draft
wants to merge 4 commits into
base: GSOC2024-RohitPrasad
Choose a base branch
from

Conversation

rohit2p
Copy link
Contributor

@rohit2p rohit2p commented Aug 12, 2024

Purpose of PR?:

introduce a new filter feature using re

@matrss
Copy link
Collaborator

matrss commented Aug 15, 2024

I think the Apply and Cancel buttons aren't really needed and just clutter the interface, instead any fetch or similar could just take the current content of the filter into account and hitting enter in the regex input should just do an update.

Also, the current changes somehow break the operations list when resizing, it no longer changes sizes with the window.

@rohit2p
Copy link
Contributor Author

rohit2p commented Aug 16, 2024

I think the Apply and Cancel buttons aren't really needed and just clutter the interface, instead any fetch or similar could just take the current content of the filter into account and hitting enter in the regex input should just do an update.

Also, the current changes somehow break the operations list when resizing, it no longer changes sizes with the window.

yes great unless i hit enter the filtered operations will only appear in the mainwindow as i hit enter the docking widget will refresh and show the filtered operations only. Thx

@joernu76
Copy link
Member

Nice!

  1. The regex filter overrides the category filter. I think we want to have bot in an AND fashion.
  2. I do not understand the "ignore archived" tickbox. In this view "archived" operations shall always be ignored. There is a view opened by the "Operation Archive" button. "Someone" broke the archiving fully and completely, but my intent is to remedy this soon. Ideally the Operation archive view gets its own regex filter.

@joernu76
Copy link
Member

Further, we need to think about the interaction between the multiple flightpath widget and this filter. Shall there be any?
Currently, the widget does not change its view when the category in the mainwindow is changed, which I deem a bug (not necessarily yours to fix, but would be nice and should be included in the fix that only "attaches" checked operations).

@rohit2p
Copy link
Contributor Author

rohit2p commented Aug 22, 2024

Further, we need to think about the interaction between the multiple flightpath widget and this filter. Shall there be any? Currently, the widget does not change its view when the category in the mainwindow is changed, which I deem a bug (not necessarily yours to fix, but would be nice and should be included in the fix that only "attaches" checked operations).

yes you have to reopen the topview for the reflection to happen definitely need a fix and I'll do my best and i also want the filtered operations to reflect in docking widget but i having trouble to find how this category filtered operations are reflecting in the docking widget

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants