Fail tests if there are any widgets left open #2150
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
matrss
force-pushed
the
cleanup-after-qt-tests
branch
3 times, most recently
from
3e95b6e to
5dffc9d
Compare
matrss
force-pushed
the
cleanup-after-qt-tests
branch
from
5dffc9d to
b945b80
Compare
matrss
force-pushed
the
cleanup-after-qt-tests
branch
7 times, most recently
from
f609975 to
8520847
Compare
Qt widgets that are not cleaned up after a test can affect the following tests. This change makes it so that tests that do not clean up after themselves will error.
By using qtbot.add_widget on the created widgets they will be automatically closed and deleted after each test.
matrss
force-pushed
the
cleanup-after-qt-tests
branch
from
8520847 to
5a65510
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Qt widgets that are not cleaned up after a test can affect the following tests. This change makes it so that tests that do not clean up after themselves will error.
Fixes #2193.
Split off from #2100.