-
Notifications
You must be signed in to change notification settings - Fork 42
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Simplify the ImageCollection class hierarchy #100
Labels
Comments
soxofaan
added a commit
that referenced
this issue
Nov 21, 2019
and remove `download` from `ImageCollection` base class. Also drop pre-0.4 support from download (issue #72)
soxofaan
added a commit
that referenced
this issue
Nov 21, 2019
…ethods from ImageCollection base class
soxofaan
added a commit
to Open-EO/openeo-geopyspark-driver
that referenced
this issue
Oct 6, 2020
soxofaan
added a commit
to Open-EO/openeo-python-driver
that referenced
this issue
Oct 6, 2020
preparation for larger process graph processing refactor preparation for Open-EO/openeo-python-client#100 (splitting client and driver data cube hierarchies)
soxofaan
added a commit
to Open-EO/openeo-geopyspark-driver
that referenced
this issue
Oct 6, 2020
preparation for Open-EO/openeo-python-client#100 (splitting client and driver data cube hierarchies)
soxofaan
added a commit
to Open-EO/openeo-python-driver
that referenced
this issue
Oct 6, 2020
preparation for larger process graph processing refactor preparation for Open-EO/openeo-python-client#100
Open
soxofaan
added a commit
that referenced
this issue
Mar 11, 2022
soxofaan
added a commit
that referenced
this issue
Mar 11, 2022
soxofaan
added a commit
that referenced
this issue
Mar 7, 2023
soxofaan
added a commit
that referenced
this issue
Mar 7, 2023
soxofaan
added a commit
that referenced
this issue
Mar 7, 2023
soxofaan
added a commit
that referenced
this issue
Mar 7, 2023
soxofaan
added a commit
that referenced
this issue
Mar 14, 2023
soxofaan
added a commit
to Open-EO/openeo-python-driver
that referenced
this issue
Mar 24, 2023
soxofaan
added a commit
to Open-EO/openeo-geopyspark-integrationtests
that referenced
this issue
Mar 24, 2023
soxofaan
added a commit
that referenced
this issue
Mar 24, 2023
ImageCollection base class has been eliminated |
soxofaan
added a commit
that referenced
this issue
Mar 29, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
We currently have a class hierarchy across openeo-python-client and openeo-geopyspark-driver:
ImageCollection
in openeo-python-client with child classesImageCollectionClient
in openeo-python-clientGeotrellisTimeSeriesImageCollection
in openeo-geopyspark-driverGeotrellisCatalogImageCollection
in openeo-geopyspark-driver, but deprecated and unused as far as I knowThis hierarchy and relationship makes sense as these classes represent the same entity (data cubes), but from different view points: client side and backend-side.
However, these client and backend contexts are also quite different and the sharing of an abstract interface shouldn't be taken too far IMHO. Some examples and notes:
download
method makes sense for the client, but is not very intuitive as verb at the backend side. Also the kind of arguments you expect to pass from client vs backend can be different.I propose to simplify/reduce the shared API of the
ImageCollectionClient
base class a bitThe text was updated successfully, but these errors were encountered: