Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Should split_job_s2grid and split_job_hex return original geometry instead of Points? #101

Open
VincentVerelst opened this issue Apr 24, 2024 · 1 comment
Labels
question Further information is requested

Comments

@VincentVerelst
Copy link
Collaborator

Currently both job splitters use the centroid of the geometry to determine which tile/hex they belong to. However, after the geometries are split per tile/hex, they aren't converted back to the original geometry, but instead kept as Points.
Would it be useful to return the original geometries instead of their centroids after the job splitting?

@VincentVerelst VincentVerelst added the question Further information is requested label Apr 24, 2024
@VictorVerhaert
Copy link
Collaborator

I think by default the original polygons should be returned, but we could provide an argument to use the centrods instead

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
question Further information is requested
Projects
None yet
Development

No branches or pull requests

2 participants