-
Notifications
You must be signed in to change notification settings - Fork 356
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fillet can not round a face #172
Comments
What do you mean by "round the face"?
|
I understand the issue. I have seen it many times. The question is what should happen when the fillet cannot be completed as specified. |
I don't know if it will be easy but the logic of this should be: If the fillet causes a face dimension to be 0 then delete that face. What should happen in my example is the gray face that was 2 mm and became 0 mm due to fillets should be deleted and the upper and bottom fillets should connect as tangents. Does that make sense? I don't know if there is an easier way to make this work but that's how it is in other commercial CAD software. |
OK, now they are tangent at the former face along the edge. What happens at the other ends? Sharp break in the curve? Changed radius of the fillet so that the other ends can be tangent to those faces? |
In my example both the top and bottom fillets have the same radius so both of them would be tangent without changing any radius. But if I understand you correctly you are asking what if they cannot be tangent due to radius difference or other constraints, from my experience in other CAD software, you should never change the other fillet's radius, keep the sharp corners and let the dimension changes in the user's control. |
I don't know if this would help in the implementation, but I believe the behavior used by commercial CAD software is equivalent to performing the fillet on each edge loop separately and then taking the intersection. So in this example we would duplicate the part, perform the top fillet on one copy, perform the bottom fillet on the other copy, and then do a boolean intersection to get the final result. As long as boolean intersections don't have some other issue, this should work for both over-fillet and critical-fillet (as is used in this issue), so two birds with one stone. |
Category
Modeling
Severity
Major
Description
I know this bug is in the original tracker 25478
but it has been 10 years since it was reported and there is no sign of any attention or progress done on this. Please someone needs to look into it since it feels like the most important problem now in FreeCAD
Expected Behavior
if the fillet radius is big enough that there are no linear faces remaining, it should round the face.
Actual Behavior
The fillet will work as long as the radius is small enough to keep some face remaining. if it is big it will not work.
Sample Code or DRAW Tcl Script
Operating System
Linux
Compiler
GCC
Bitness
64-bit
OCCT Version
latest
The text was updated successfully, but these errors were encountered: