Add support for matches

[Olen]

Should probably refactor event to a class first, so match can be a subclass of event

[Olen]

New parameters for matches:

 'matchEvent': True,
 'matchInfo': {
               'opponentName': 'Hasle-Løren Hvit',
               'opponentScore': 6,
               'scoresFinal': True,
               'scoresPublic': True,
               'scoresSet': True,
               'scoresSetEver': True,
               'teamName': 'Grüner lilla',
               'teamScore': 11,
               'type': 'AWAY'
},

type can be HOME and AWAY

[elliot-100]

Can't help with this one -- at least not with real-world examples -- as Matches aren't relevant/available to my clubs (documentation on which sports are supported).

[Olen]

They are just regular events, but with a few more fields (noted in the first comment)

[Bart274]

This is something that would be really useful. Any progress on this?

[elliot-100]

Olen raised a PR against my separate Spond-classes package: elliot-100/Spond-classes#148

I should be able to add it in the next few weeks.

[Bart274]

Nice. That would really help us a lot 😊

[elliot-100]

@Bart274 can you have a look at the PR elliot-100/Spond-classes#148 please? I don't think I can tag you from there.

[Bart274]

@elliot-100 it looks good. But I don’t see why that PR is blocking any development for this issue here? I use the spond package without the spond-classes at this moment.

[elliot-100]

@Bart274 given:

They are just regular events, but with a few more fields

I'm not clear what you want spond to do? Could you give an example?

[Bart274]

@elliot-100 well, the matchinfo fields are missing in the event template:

Spond/spond/_event_template.py

Line 5 in fe6db62

_EVENT_TEMPLATE: JSONDict = {

Since these fields are missing, even when you retrieve an existing event from Spond that contains the data, whenever you call the method to update existing events, it will remove the data from the event in the function as it’s keys are missing in the template.

Spond/spond/spond.py

Line 354 in fe6db62

for key in base_event:

So we can’t update the matchinfo of events through this API.

[elliot-100]

OK, can you raise a separate bug issue instead, please, as this doesn't really relate to adding a class interface for events.

(although I can see that the list of additional params might give that impression)

[Bart274]

@elliot-100 but isn’t this the point of this ticket? The issue is to add support for matches… 😄
We can retrieve the matchinfo from existing events just fine, but we can’t update them. What else is this ticket for?

[elliot-100]

The package does support matches in general, like any other event.

@Olen, who is the author of the package, created this issue and has decided that at this time, what they want is best implemented as an addition to my existing class interface. And so has raised a linked closing PR there. That is their perogative.

It was not clear from your initial supporting comment in the conversation that you were expecting something else. So I (the other main contributor to this package) have just spent some development time on this during holidays, partly in order to help you.

You could now help us and other users and contributors by raising a separate issue, so we, and you, can track it more easily. For example you might wish to raise a PR yourself against that in order to contribute further.

[Bart274]

@elliot-100 matches are supported to retrieve information. However, since the matchevent & matchinfo keys are missing in the event template, you can't use the update_event method to update that information.
I have added that information in the event template in this PR: #169

[Olen]

My main point was that I did not want to do any major changes here before the classes PR was merged, as I really think that is the way forward.

I have not followed the development of that branch tightly, so I am not sure how close to ready that branch is.
But if it feals mature enough, I am more than happy to merge it here and create a breaking release.