Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

When creating a Basic Tab and choosing TypeScript as the language, TTK still creates the code in JavaScript #12432

Open
AE-MS opened this issue Sep 20, 2024 · 3 comments
Assignees
Labels
investigating TA:Compute Team Area: Compute

Comments

@AE-MS
Copy link

AE-MS commented Sep 20, 2024

Describe the bug
Despite choosing TypeScript as the language when creating a new "Basic Tab," TTK still creates the code as JavaScript in teamsapp.js

To Reproduce
Steps to reproduce the behavior:

  1. Use TTK to create a new app
  2. Choose "Tab"
  3. Choose "Basic Tab"
  4. Choose "TypeScript"
  5. Enter a folder and app name as appropriate

Expected behavior
The created app to be authored in TypeScript. In fact, it is still authored in JavaScript.

Screenshots
{FB525EB3-AA45-4A28-B67C-5595A7CE279A}

VS Code Extension Information (please complete the following information):

  • OS: Windows 11
  • Version 5.8.1

CLI Information (please complete the following information):
I don't know what this section is looking for

Copy link
Contributor

Thank you for contacting us! Any issue or feedback from you is quite important to us. We will do our best to fully respond to your issue as soon as possible. Sometimes additional investigations may be needed, we will usually get back to you within 2 days by adding comments to this issue. Please stay tuned.

@microsoft-github-policy-service microsoft-github-policy-service bot added the needs attention This issue needs the attention of a contributor. label Sep 20, 2024
@adashen adashen added investigating TA:Compute Team Area: Compute labels Sep 23, 2024
@Yimin-Jin
Copy link
Contributor

We included a .js file in our TypeScript project because the basic tab is designed to be lightweight and uses HTML to directly access JavaScript. Since browsers don't support TypeScript files directly, we opted for JavaScript here.

@adashen adashen removed the needs attention This issue needs the attention of a contributor. label Sep 24, 2024
@AE-MS
Copy link
Author

AE-MS commented Sep 24, 2024

We included a .js file in our TypeScript project because the basic tab is designed to be lightweight and uses HTML to directly access JavaScript. Since browsers don't support TypeScript files directly, we opted for JavaScript here.

Isn't the user explicitly saying that they want a TypeScript app by choosing the "TypeScript" option when creating the app? If they wanted a JavaScript app they would have selected the "JavaScript" option.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
investigating TA:Compute Team Area: Compute
Projects
None yet
Development

No branches or pull requests

3 participants