Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Think through methodology of config validation checking #503

Open
hkalodner opened this issue Apr 10, 2022 · 0 comments
Open

Think through methodology of config validation checking #503

hkalodner opened this issue Apr 10, 2022 · 0 comments
Labels
node Changes the node software

Comments

@hkalodner
Copy link
Contributor

We currently have two areas of the code we do config validation checking, inside createNodeImpl and inside the node cmd. We should come up with a clear consistent methodology for which checks go where.

Inspired by the comment in https://github.com/OffchainLabs/nitro/pull/501/files#r846801426
@hkalodner hkalodner added the node Changes the node software label Apr 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
node Changes the node software
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@hkalodner