Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reliance on Converto / Newtonsoft.Json #100

Open
slimshader opened this issue Sep 15, 2022 · 3 comments
Open

Reliance on Converto / Newtonsoft.Json #100

slimshader opened this issue Sep 15, 2022 · 3 comments
Labels
good first issue Good for newcomers refactoring Improve source code which is not related to any bug or feature

Comments

@slimshader
Copy link

Hi,

I just ported this awesome library to Unity (and works like a charm so far) but was hoping to further remove the dependence on Converto for (IsDeepEqual calls) which in turn depends on outdated version of Newtonsoft.Json. My question: if my state is a record, so I know the comparisons are deep, can this code be simplified to not rely on IsDeepEqual?

@Odonno
Copy link
Owner

Odonno commented Sep 29, 2022

I am glad it works great on Unity.

Since we now have System.Text.Json, I believe we can remove the dependency from Newtonsoft. I will take a look when I have some free time.

@Odonno Odonno added good first issue Good for newcomers refactoring Improve source code which is not related to any bug or feature labels Sep 29, 2022
@th3d0g
Copy link

th3d0g commented Feb 8, 2024

Any update on this?

@Odaimoko
Copy link

Odaimoko commented Jun 9, 2024

Hi @slimshader . Is it possible to share some thoughts on porting to Unity? There are to many allocations in ReduxSimple's implmentation. While this is not a thing in WPF or other platforms, in Unity we tend to minimize heap alloc. So how do you manage to do it?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers refactoring Improve source code which is not related to any bug or feature
Projects
None yet
Development

No branches or pull requests

4 participants