Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enable websocket polling for netcore #431

Closed
wants to merge 1 commit into from
Closed

Enable websocket polling for netcore #431

wants to merge 1 commit into from

Conversation

Discolai
Copy link

Background

Our team want to use this framework in a polling fashion over websockets. This is currently not supported in the dotnet6 package due to an issue with custom certificate handling in early dotnet core versions #47

This issue has since been fixed by exposing ClientWebSocketOptions.RemoteCertificateValidationCallback dotnet/corefx#28141

Results

Fixes #170

Before

Polling with a websocket connection on dotnet6 would throw NotSupportedException("The netstandard build of this library cannot act as the client in a WebSocket polling setup");

After

Polling with a websocket connection on net6 will now use ClientWebSocketOptions.RemoteCertificateValidationCallback to validate the remote certificate

How to review this PR

Quality ✔️

Pre-requisites

  • I have read How we use GitHub Issues for help deciding when and where it's appropriate to make an issue.
  • I have considered informing or consulting the right people, according to the ownership map.
  • I have considered appropriate testing for my change.

@Discolai Discolai requested a review from a team as a code owner August 15, 2023 20:05
@CLAassistant
Copy link

CLAassistant commented Aug 15, 2023 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@nathanwoctopusdeploy
Copy link
Contributor

nathanwoctopusdeploy commented Aug 15, 2023 •
edited
Loading

Related PR (out of date and very noisy Draft with many other changes!!) #259

@nathanwoctopusdeploy
Copy link
Contributor

nathanwoctopusdeploy commented Aug 15, 2023 •
edited
Loading

Thanks @Discolai. We did take a look at supporting this scenario now that it's supported with the shift from netstandard2.0 to net6.0 in our target frameworks.

However, it wasn't merged because it was assigned a lower priority. I'll create a task on our board for this, as it may be more important given some upcoming changes to Tentacle we intend to make.

@LukeButters
Copy link
Contributor

In the meantime is a HTTP proxy a viable alternative?

@Discolai
Copy link
Author

Thanks @Discolai. We did take a look at supporting this scenario now that it's supported with the shift from netstandard2.0 to net6.0 in our target frameworks.

However, it wasn't merged because it was assigned a lower priority. I'll create a task on our board for this, as it may be more important given some upcoming changes to Tentacle we intend to make.

Sorry I did not see that PR 😅

Thank you for giving it another look 😄

@Discolai
Copy link
Author

In the meantime is a HTTP proxy a viable alternative?

I am not sure, but I will give it a look

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Support WebSockets on .NET Core
5 participants
@Discolai @CLAassistant @nathanwoctopusdeploy @LukeButters @sburmanoctopus