In a dockerized environment, FileWriterGeneratorStrategyTest#testGenerateWillFailIfTmpFileCannotBeWrittenToDisk() fails

[Ocramius]

To reproduce:

FROM php:7.4-cli

VOLUME /app

WORKDIR /app

docker build -t foo .
docker run -ti -v $(pwd):/app foo vendor/bin/phpunit

The error is:

1) ProxyManagerTest\GeneratorStrategy\FileWriterGeneratorStrategyTest::testGenerateWillFailIfTmpFileCannotBeWrittenToDisk
Failed asserting that exception of type "ProxyManager\Exception\FileNotWritableException" is thrown.

Perhaps the test is a bit weak: @michalbundyra do you know how to harden this test?

ProxyManager/tests/ProxyManagerTest/GeneratorStrategy/FileWriterGeneratorStrategyTest.php

Lines 44 to 59 in 934d54c

	private string $tempDir;
	private Closure $originalErrorHandler;
	protected function setUp(): void
	{
	parent::setUp();
	$this->tempDir = tempnam(sys_get_temp_dir(), 'FileWriterGeneratorStrategyTest');
	$this->originalErrorHandler = static function (): bool {
	throw new ErrorException();
	};
	unlink($this->tempDir);
	mkdir($this->tempDir);
	set_error_handler($this->originalErrorHandler);
	}

ProxyManager/tests/ProxyManagerTest/GeneratorStrategy/FileWriterGeneratorStrategyTest.php

Lines 108 to 127 in 934d54c

	public function testGenerateWillFailIfTmpFileCannotBeWrittenToDisk(): void
	{
	$tmpDirPath = $this->tempDir . '/' . uniqid('nonWritable', true);
	mkdir($tmpDirPath, 0555, true);
	$locator = $this->createMock(FileLocatorInterface::class);
	$generator = new FileWriterGeneratorStrategy($locator);
	$tmpFile = $tmpDirPath . '/' . uniqid('FileWriterGeneratorStrategyFailedFileWriteTest', true) . '.php';
	$namespace = 'Foo';
	$className = UniqueIdentifierGenerator::getIdentifier('Bar');
	$fqcn = $namespace . '\\' . $className;
	$locator
	->method('getProxyFileName')
	->with($fqcn)
	->willReturn($tmpFile);
	$this->expectException(FileNotWritableException::class);
	$generator->generate(new ClassGenerator($fqcn));
	}

The source being tested:

ProxyManager/src/ProxyManager/GeneratorStrategy/FileWriterGeneratorStrategy.php

Lines 43 to 61 in 934d54c

	public function generate(ClassGenerator $classGenerator): string
	{
	$generatedCode = $classGenerator->generate();
	assert(is_string($generatedCode));
	$className = $classGenerator->getNamespaceName() . '\\' . $classGenerator->getName();
	$fileName = $this->fileLocator->getProxyFileName($className);
	set_error_handler($this->emptyErrorHandler);
	try {
	FileWriter::writeFile($fileName, "<?php\n\n" . $generatedCode);
	return $generatedCode;
	} catch (FileWriterException $e) {
	throw FileNotWritableException::fromPrevious($e);
	} finally {
	restore_error_handler();
	}
	}

[Ocramius]

Note: I just noticed this because I no longer run PHP 7.x on my systems.