Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

The staticProxyConstructor method of all proxies can have a self return type #401

Open
Ocramius opened this issue Dec 5, 2017 · 4 comments
Open

The staticProxyConstructor method of all proxies can have a self return type #401

Ocramius opened this issue Dec 5, 2017 · 4 comments
Assignees
@Ocramius
Labels
enhancement
Milestone
2.15.0

Comments

@Ocramius
Copy link
Owner

Ocramius commented Dec 5, 2017

No description provided.

@Ocramius
Copy link
Owner Author

After careful inspection, zendframework/zend-code does not allow specifying : self on a return type.

@Ocramius Ocramius self-assigned this Feb 27, 2019
@Ocramius Ocramius added this to the 2.3.0 milestone Feb 27, 2019
@Ocramius
Copy link
Owner Author

Also, cannot be currently done because it would first need https://wiki.php.net/rfc/covariant-returns-and-contravariant-parameters

The test suite tries to proxy over pre-existing proxies, in which case a type restriction on a return type is only possible if variance checks are implemented in php-src.

@Ocramius Ocramius removed their assignment Feb 27, 2019
@Ocramius Ocramius removed this from the 2.3.0 milestone Feb 27, 2019
@Ocramius
Copy link
Owner Author

Ocramius commented Dec 2, 2020

This will be feasible with the new static type in PHP 8

@Ocramius Ocramius added this to the 2.11.0 milestone Dec 2, 2020
@Ocramius Ocramius self-assigned this Dec 2, 2020
@Ocramius Ocramius modified the milestones: 2.11.0, 2.12.0 Dec 30, 2020
@Ocramius
Copy link
Owner Author

No time to get it in 2.11.0, hence moving it to 2.12.0

@Ocramius Ocramius modified the milestones: 2.12.0, 2.13.0 May 25, 2021
@Ocramius Ocramius modified the milestones: 2.13.0, 2.14.0 Jun 9, 2021
@Ocramius Ocramius modified the milestones: 2.14.0, 2.15.0 Feb 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Ocramius Ocramius

Labels
enhancement
Projects
None yet
Milestone
2.15.0
Development

No branches or pull requests
1 participant
@Ocramius