Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Estimation time when downloading scalardata in multiple pages is not near the actual case sometimes #45

Closed
kan-fu opened this issue Sep 17, 2024 · 0 comments · Fixed by #46
Closed

Estimation time when downloading scalardata in multiple pages is not near the actual case sometimes #45

kan-fu opened this issue Sep 17, 2024 · 0 comments · Fixed by #46
Assignees
@kan-fu

Comments

@kan-fu
Copy link
Collaborator

kan-fu commented Sep 17, 2024

When running

deviceCode = 'RBRQUARTZ3BPR202321'

deployments = pd.DataFrame(onc.getDeployments({'deviceCode':deviceCode}))
d = onc.getDirectByLocation({'locationCode':deployments.iloc[1]['locationCode'],
                             'deviceCategoryCode':'BPR',
                             'sensorCategoryCodes':'pressure',
                             'dateFrom':deployments.iloc[1]['begin'],
                             'dateTo':'2020-09-30',#deployments.iloc[1]['end'],
                             'resampleType':'avg',
                             'qualityControl':'clean',
                             'resamplePeriod':1},allPages=True)

The estimated pages is 6 pages, but from the log it is more than that clearly.
Screenshot 2024-09-05 at 3 53 30 PM
@kan-fu kan-fu self-assigned this Sep 17, 2024
@kan-fu kan-fu linked a pull request Sep 23, 2024 that will close this issue
fix: use total_seconds instead of seconds in the datetime #46
Merged
@kan-fu kan-fu closed this as completed Sep 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@kan-fu kan-fu

Labels
None yet
Projects
Python Client Library Development
Archived in project
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: use total_seconds instead of seconds in the datetime OceanNetworksCanada/api-python-client
1 participant
@kan-fu