Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deactivate broken cheat sheet links #732

Closed
wants to merge 1 commit into from
Closed

Deactivate broken cheat sheet links #732

wants to merge 1 commit into from

Conversation

szh
Copy link

@szh szh commented Nov 1, 2022

Fixes #723 by removing square brackets around title of cheat sheets that aren't published yet so Markdown doesn't interpret them as links to a URL called "Coming Soon"

Signed-off-by: Shlomo Heigh [email protected]

@szh
Copy link
Author

szh commented Nov 16, 2022

It's been two weeks since I submitted this. Can we please get a review? Thanks :⁠-⁠)

Copy link
Contributor

@kingthorin kingthorin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Outside approval for whatever that’s worth. Looks good to me assuming none of those CheatSheets have released in the mean time.

@sslHello
Copy link
Collaborator

Hi @szh,
thank you for your PR.
We were waiting for the Cheat Sheet Project ;-). Now this has been fixed by #741 and #742.
Cheers Torsten

@sslHello sslHello closed this Feb 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Broken link on Insecure Design page
3 participants