Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Building List Scroll Lag #316

Open
solderq35 opened this issue Apr 16, 2024 · 0 comments
Open

Building List Scroll Lag #316

solderq35 opened this issue Apr 16, 2024 · 0 comments
Labels
data-layer Includes cache, API calls, or data transformations in VueX enhancement New feature or request priority-low UI/UX Frontend web dev issues, UI/UX

Comments

@solderq35
Copy link
Contributor

solderq35 commented Apr 16, 2024

EDIT: On further investigation, there doesn't seem to be much lag after the page has been given some time to load, so maybe this is more of an issue of waiting on some background API calls to complete (e.g. /allBuildings), than any kind of Vue State / image rendering issue.

Probably fine to leave this bug as not too consequential for now.

===

There's a noticeable lag for me scrolling through the building list (https://dashboard.sustainability.oregonstate.edu/#/buildings), at least on PC on chrome browser.

There seems to be a scrolling "max speed" before the animation starts to have hiccups; scrolling slowly does not trigger any animation stutters.

Oddly, the scrolling had no lag on mobile (iPhone, safari). Maybe because on mobile only one column is rendered.

Didn't have time to diagnose the issue but I suspect it has something to do with image rendering (maybe make the thumbnails smaller or remove them), the Vue State logic in building_list component (maybe there is a state variable that can be optimized?), or maybe we can just reduce the number of columns shown on desktop as well.

Some ideas here for Vue State optimizations: https://stackoverflow.com/questions/43913454/vue-v-for-performance-is-poor

Another possibility is paginating the data on the frontend (only show a certain number of buildings per page), but let's make sure the user can still search the whole building list (when typing into the search bar) if we go that route.

@solderq35 solderq35 added data-layer Includes cache, API calls, or data transformations in VueX enhancement New feature or request priority-low UI/UX Frontend web dev issues, UI/UX labels Apr 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
data-layer Includes cache, API calls, or data transformations in VueX enhancement New feature or request priority-low UI/UX Frontend web dev issues, UI/UX
Projects
None yet
Development

No branches or pull requests

1 participant