Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Resolve navdir display logic (vuex state issue) #293

Open
solderq35 opened this issue Jan 18, 2024 · 1 comment
Open

Resolve navdir display logic (vuex state issue) #293

solderq35 opened this issue Jan 18, 2024 · 1 comment
Assignees
@solderq35
Labels
data-layer Includes cache, API calls, or data transformations in VueX priority-low

Comments

@solderq35
Copy link
Contributor

solderq35 commented Jan 18, 2024 •
edited
Loading

Maybe. Pending further communication from management (email from Brandon / Ross). If we want to show navdir on comparison pages, need to tweak logic for which parts of navdir are shown on comparison page.

If this isn't needed, the publicview / otherview / etc stuff on navdir can be removed
@solderq35 solderq35 changed the title Show Navdir on comparison pages Resolve navdir display logic Jan 18, 2024
@solderq35 solderq35 added the question Further information is requested label Jan 22, 2024
@solderq35
Copy link
Contributor Author

Based on feedback we do not need to ever show any part of the navdir on comparison screens. We can remove otherview and publicview etc.

@solderq35 solderq35 added data-layer Includes cache, API calls, or data transformations in VueX and removed question Further information is requested labels Jan 23, 2024
@solderq35 solderq35 changed the title Resolve navdir display logic Resolve navdir display logic (vuex state issue) Jan 23, 2024
@solderq35 solderq35 mentioned this issue Feb 3, 2024
Closed
@solderq35 solderq35 self-assigned this Feb 7, 2024
@solderq35 solderq35 mentioned this issue Jun 17, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@solderq35 solderq35

Labels
data-layer Includes cache, API calls, or data transformations in VueX priority-low
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@solderq35