Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reuse dqv:Metric instead of TestSpecification or Test #13

Open
huberrob opened this issue Sep 18, 2024 · 6 comments
Open

Reuse dqv:Metric instead of TestSpecification or Test #13

huberrob opened this issue Sep 18, 2024 · 6 comments

Comments

@huberrob
Copy link

At https://ostrails.github.io/FAIR_assessment_output_specification/release/0.0.1 there is a class called https://w3id.org/ftr#TestSpecification which is not part of the image at FAIRTestResult_diagram_v4.drawio.png . But there I see a ftr:Test class.

I assume they are the same thing? If 'Test' is the latest name, I would recommend to rename it back to TestSpecification or e.g. to Metric because 'Test' is quite generic and could also mean an activity (test activity)

To make the model compatible with DQV I would propose to define it as a subclass of dqv:Metric or just reuse dqv:Metric in the model?

@markwilkinson
Copy link
Contributor

Tests and Metrics are different things in the OSTrails terminology and component model...

@dgarijo
Copy link
Collaborator

dgarijo commented Sep 18, 2024 via email

@huberrob
Copy link
Author

Yes that would be good, because at the README I just discovered the sentence "Test: A test (service) implementing a dqv:Metric" so then it is rather a TestActivity? But it seems to be a dcat:DataService so it is the API/software etc which is performing the test?

If so I would propose to rename it to something like 'TestingAgent' which is a subclass of prov:SoftwareAgent in addition to dact:DataService

@dgarijo
Copy link
Collaborator

dgarijo commented Sep 18, 2024 via email

@huberrob
Copy link
Author

Ok, so maybe 'TestService' would be a better name for this? Just 'Test' is very generic and thus a bit confusing

@dgarijo
Copy link
Collaborator

dgarijo commented Sep 18, 2024

Hmm, i do not disagree in principle, but the way I see it is more a test description, and "test" fits quite well. Let me update the spec next week and we can come back to the issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants