CMake config currently has a hard-coded include instead of CMAKE_INSTALL_INCLUDEDIR

[thbeu]

          Using absolute paths is a problem already now: The CMake config currently has a hard-coded `include` instead of `CMAKE_INSTALL_INCLUDEDIR`.

Originally posted by @dg0yt in #75 (comment)

[rouault]

@thbeu is this issue still opened?

[thbeu]

It's still here, but seems configurable.

shapelib/CMakeLists.txt

Lines 54 to 68 in 2cc2975

	# Set up install locations.
	set(
	CMAKE_INSTALL_BINDIR bin
	CACHE PATH "install location for user executables"
	)
	set(
	CMAKE_INSTALL_LIBDIR lib
	CACHE PATH "install location for object code libraries"
	)
	set(
	CMAKE_INSTALL_INCLUDEDIR include
	CACHE PATH "install location for C header files"
	)

Note, that @dg0yt originally raised the issue.

[thbeu]

Or rather here:

shapelib/CMakeLists.txt

Lines 133 to 137 in 2cc2975

	target_include_directories(${PACKAGE}
	INTERFACE
	$<BUILD_INTERFACE:${CMAKE_CURRENT_SOURCE_DIR}>
	$<INSTALL_INTERFACE:include>
	)

[dg0yt]

Or rather here:

shapelib/CMakeLists.txt

Lines 133 to 137 in 2cc2975

	target_include_directories(${PACKAGE}
	INTERFACE
	$<BUILD_INTERFACE:${CMAKE_CURRENT_SOURCE_DIR}>
	$<INSTALL_INTERFACE:include>
	)

And that's the INSTALL_INTERFACE which needs to be fixed.

[thbeu]

Or rather here:

shapelib/CMakeLists.txt

Lines 133 to 137 in 2cc2975

	target_include_directories(${PACKAGE}
	INTERFACE
	$<BUILD_INTERFACE:${CMAKE_CURRENT_SOURCE_DIR}>
	$<INSTALL_INTERFACE:include>
	)

And that's the INSTALL_INTERFACE which needs to be fixed.

Right. Do you know how to do?

[dg0yt]

It was part of the comment: replace include with ${CMAKE_INSTALL_INCLUDEDIR}.

[dg0yt]

(This was initially suggested for a drive-by fix when using the same variable for the pc file.)

[thbeu]

Right. As simple as that and available via #139.

[thbeu]

(This was initially suggested for a drive-by fix when using the same variable for the pc file.)

Thanks for reminding. I changed to ${includedir} which we introduced in #135.