-
-
Notifications
You must be signed in to change notification settings - Fork 2.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Coordinate transformation: enhacements related to PointMotionOperation and CoordinateMetadata #8340
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rouault
force-pushed
the
pointmotionoperation
branch
from
September 6, 2023 08:56
4020da6
to
bdb654c
Compare
rouault
added a commit
to rouault/PDAL
that referenced
this pull request
Sep 6, 2023
…nce built from SetFromUserInput() This is useful to get the epoch for a SpatialReference built from a string like 'urn:ogc:def:coordinateMetadata:AUTHORTIY::CODE code' (since OSGeo/gdal#8340 and OSGeo/PROJ#3884), which resolves to a CoordinateMetadata object with a CRS and potentially a coordinate epoch
rouault
added a commit
to rouault/PDAL
that referenced
this pull request
Sep 11, 2023
…nce built from SetFromUserInput() This is useful to get the epoch for a SpatialReference built from a string like 'urn:ogc:def:coordinateMetadata:AUTHORTIY::CODE code' (since OSGeo/gdal#8340 and OSGeo/PROJ#3884), which resolves to a CoordinateMetadata object with a CRS and potentially a coordinate epoch
…a (if PROJ >= 9.4)
…SRC_COORDINATE_EPOCH != DST_COORDINATE_EPOCH
rouault
force-pushed
the
pointmotionoperation
branch
from
September 15, 2023 09:42
bdb654c
to
c4f5b92
Compare
rouault
added a commit
to rouault/PDAL
that referenced
this pull request
Sep 15, 2023
…nce built from SetFromUserInput() This is useful to get the epoch for a SpatialReference built from a string like 'urn:ogc:def:coordinateMetadata:AUTHORTIY::CODE code' (since OSGeo/gdal#8340 and OSGeo/PROJ#3884), which resolves to a CoordinateMetadata object with a CRS and potentially a coordinate epoch
hobu
pushed a commit
to PDAL/PDAL
that referenced
this pull request
Sep 18, 2023
* SpatialReference::set(): store coordinate epoch from OGRSpatialReference built from SetFromUserInput() This is useful to get the epoch for a SpatialReference built from a string like 'urn:ogc:def:coordinateMetadata:AUTHORTIY::CODE code' (since OSGeo/gdal#8340 and OSGeo/PROJ#3884), which resolves to a CoordinateMetadata object with a CRS and potentially a coordinate epoch * SrsTransform: make sure to propagate coordinate epoch when rebuilding OGRSpatialReference objects * SpatialReference: add a m_wkt2 member filled in set() and returned by getWKT2() * SrsTransform: use SpatialReference::getWKT2() This limits the loss of information, particularly for CRS like 'urn:ogc:def:coordinateMetadata:NRCAN::NAD83_CSRS_1997_MTM7_HT2_1997' which include a GEOIDMODEL[] node, that would be lost otherwise * SpatialReference::isWKT2(): add missing keywords, and fix typo VERITCALCRS -> VERTICALCRS
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Builds upon the enhancements of PROJ OSGeo/PROJ#3884 "Add support for transformations involving coordinate epoch changes (PointMotionOperation), mostly for Canadian NAD83(CSRS) case"
With that PR and PROJ's PR: