Removed leftover setting of CMAKE_REQUIRED_FLAGS #4322
Conversation
|
This I think I should have done back in #3425. The Werror removed in this PR is causing me grief in VTK: https://gitlab.kitware.com/vtk/vtk/-/issues/19532 |
| if(MSVC) | ||
| set(CMAKE_REQUIRED_FLAGS "${CMAKE_C_FLAGS} /WX /W4") | ||
| else() | ||
| set(CMAKE_REQUIRED_LIBRARIES m) |
There was a problem hiding this comment.
we should probably keep set(CMAKE_REQUIRED_LIBRARIES m)
There was a problem hiding this comment.
So the whole block isn't there just for the now-removed check_c_source_compiles?
There was a problem hiding this comment.
hum, I see there were past math function detection in 2622d38, but they have gone to now. So, probably disregard my comment and this is indeed no longer needed
|
your pull request is based on a not so recent master. Can you please rebase it on top of latest master HEAD ? |
Back in 88d91f7 I removed a `check_c_source_compiles` to detect some pthread stuff and converted to std::mutex instead. This stuff I believe I should have removed back then too. The -Werror caused a problem in VTK, which still has the `check_c_source_compiles`, because a totally unrelated warning made the try-compile fail when it should have passed.
seanm
force-pushed
the
Werror-pthread
branch
from
3c38029 to
a759224
Compare
Weird, I swear I did, but indeed not. Should be fixed now. |
Back in 88d91f7 I removed a
check_c_source_compilesto detect some pthread stuff and converted to std::mutex instead.This stuff I believe I should have removed back then too.
The -Werror caused a problem in VTK, which still has the
check_c_source_compiles, because a totally unrelated warning made the try-compile fail when it should have passed.