Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change originates from Conan conan-io/conan-center-index#21512 (comment).
I create an explicit SQLite::SQLite3 target library and then add that target. The target has the include directory property set inside it, so we no longer have to do a
target_include_directories
. This makes it easier for package managers to control the SQLite3 dependency, and it aligns with more recent Cmake version sqlite3 usage.Both vcpkg and conan are forced to patch the PROJ CMakeLists.txt so that they can inject their own Sqlite3 right now, but if we can instead link a
SQLite::SQLite3
target, package managers can just make sure that that target is defined before trying to build PROJ.Another alternative is requiring a more recent Cmake version and using built-in FindSQLite3. I think that may be a more involved change though.