TEE_SetTAPersistentTime() is not persistent accross reboots

[jforissier]

The TEE Internal Core API specification for function TEE_SetTAPersistentTime() mentions:

The modification is atomic and persistent across device reboots.

The current implementation keeps time offsets in memory and therefore does not comply to the requirement.

[Sadiq1811]

Upon executing xtest 1006, i see the log from https://github.com/OP-TEE/optee_test/blob/master/ta/os_test/os_test.c#L577
is this log expected and related to this bug?

[Sadiq1811]

Furthermore, after https://github.com/OP-TEE/optee_test/blob/master/ta/os_test/os_test.c#L592, TA time is printed as TA time 0.000.
It's a bit confusing because TEE_GetTAPersistentTime() returned with TEE_SUCCESS and isn't populating the time!!

[jforissier]

@Sadiq1811 what you are observing is perfectly normal.

• The first call to TEE_GetTAPersistentTime() returns TEE_ERROR_TIME_NOT_SET because TEE_SetTAPersistentTime() hasn't been called yet
• The second call returns 0.000 because it happens immediately (less than one millisecond) after TEE_SetTAPersistentTime().