NVIDA partitions layout and <partition> entry

[AndersGnistrup]

Hello

I have just started to finalize a port from 35.5 to jetson 36.3 and I have a issue with the id= entry.
From /flash_l4t_nvme_rootfs_ab.xml:

---snip--
</partition>

I have an additional partition to fill the end of disk

<partition name="DATA" type="data">
            <allocation_policy> sequential </allocation_policy>
            <filesystem_type> basic </filesystem_type>
            <size> 18432 </size>
            <file_system_attribute> 0 </file_system_attribute>
            <allocation_attribute> 0x808 </allocation_attribute>
            <percent_reserved> 0 </percent_reserved>
            <description> **Required.** Automatically takes all remaining space on the device except that
              occupied by the `secondary_gpt` partition. Allocation attribute must be set to 0x808.
              May be mounted and used to store user data. </description>
</partition>

This should be OK according to the documentation but I get some odd errors.

Rootfs device: nvme0n1p1
Waiting for Jetson to appear on USB.............[found: 1-1]
== Step 1: Signing binaries at 2024-08-28T07:59:34+02:00 ==
cp: cannot stat 'signed/*': No such file or directory
cp: cannot stat 'signed/flash.xml.tmp': No such file or directory
sed: can't read flash.xml.tmp: No such file or directory
== Step 2: Boot Jetson via RCM at 2024-08-28T07:59:49+02:00 ==
Found Jetson device in recovery mode at USB 1-1
== Step 3: Sending flash sequence commands at 2024-08-28T07:59:53+02:00 ==
Waiting for USB storage device flashpkg from 3af0693b........[/dev/sda]
Device size in blocks: 262144
Unmounted /dev/sda.
== Step 4: Writing partitions on external storage device at 2024-08-28T08:00:18+02:00 ==
Waiting for USB storage device nvme0n1 from 3af0693b...[/dev/sda]
Traceback (most recent call last):
  File "/home/agn/work/tm-sdk-tm5/build/flash/nvflashxmlparse", line 483, in <module>
    ret = main()
          ^^^^^^
  File "/home/agn/work/tm-sdk-tm5/build/flash/nvflashxmlparse", line 408, in main
    rewrite_layout(args.filename, args.rewrite_contents_from.split(','), outf)
  File "/home/agn/work/tm-sdk-tm5/build/flash/nvflashxmlparse", line 266, in rewrite_layout
    maptree = ET.parse(mapfile)
              ^^^^^^^^^^^^^^^^^
  File "/usr/lib/python3.12/xml/etree/ElementTree.py", line 1204, in parse
    tree.parse(source, parser)
  File "/usr/lib/python3.12/xml/etree/ElementTree.py", line 569, in parse
    self._root = parser._parse_whole(source)
                 ^^^^^^^^^^^^^^^^^^^^^^^^^^^
xml.etree.ElementTree.ParseError: no element found: line 1, column 0
Traceback (most recent call last):
  File "/home/agn/work/tm-sdk-tm5/build/flash/nvflashxmlparse", line 483, in <module>
    ret = main()
          ^^^^^^
  File "/home/agn/work/tm-sdk-tm5/build/flash/nvflashxmlparse", line 426, in main
    layout = PartitionLayout(args.filename)
             ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/home/agn/work/tm-sdk-tm5/build/flash/nvflashxmlparse", line 142, in __init__
    tree = ET.parse(configfile)
           ^^^^^^^^^^^^^^^^^^^^
  File "/usr/lib/python3.12/xml/etree/ElementTree.py", line 1204, in parse
    tree.parse(source, parser)
  File "/usr/lib/python3.12/xml/etree/ElementTree.py", line 569, in parse
    self._root = parser._parse_whole(source)
                 ^^^^^^^^^^^^^^^^^^^^^^^^^^^
xml.etree.ElementTree.ParseError: no element found: line 1, column 0
No partition definitions found in initrd-flash.xml
ERR: write failure to external storage at 2024-08-28T08:00:21+02:00
agn@AndersGnistrup:~/work/tm-sdk-tm5/build/flash$ bitbake tm-core-image
WARNING: Host distribution "ubuntu-24.04" has not been validated with this version of the build system; you may possibly experience unexpected failures. It is recommended that you use a tested distribution.
Loading cache: 100% |######################################################################################################################################################################################| Time: 0:00:00
Loaded 4947 entries from dependency cache.
NOTE: Resolving any missing task queue dependencies

Build Configuration:
BB_VERSION           = "2.8.0"
BUILD_SYS            = "x86_64-linux"
NATIVELSBSTRING      = "universal"
TARGET_SYS           = "aarch64-poky-linux"
MACHINE              = ""
DISTRO               = "-core-linux"
DISTRO_VERSION       = "0.1.0"
TUNE_FEATURES        = "aarch64 armv8a crc"
TARGET_FPU           = ""
meta                 
meta-poky            
meta-yocto-bsp       = "HEAD:c5627ab06fc07221237b9a7059ac378ea80578f8"
meta-oe              
meta-python          
meta-networking      = "HEAD:1235dd4ed4a57e67683c045ad76b6a0f9e896b45"
meta-tegra           = "HEAD:54795112feccd4411684ab2795cb98b5bc724d67"
meta-swupdate        = "HEAD:1600c74ed6d9eabc15a680a7a4cb359aa537bd65"
meta-qt5             = "scartsgap:eb828418264a49b8d00035cb3d7b12fcea3be801"
meta-tm              = "tegra36.3:7832ed780ca51c1f0d9e1302f551800626dd53bc"

Sstate summary: Wanted 5 Local 0 Mirrors 0 Missed 5 Current 2104 (0% match, 99% complete)###############################################################################################                   | ETA:  0:00:00
Removing 4 stale sstate objects for arch 5: 100% |#################################################################################################################################################| Time: 0:00:00
NOTE: Executing Tasks
NOTE: Tasks Summary: Attempted 4464 tasks of which 4444 didn't need to be rerun and all succeeded.

Summary: There was 1 WARNING message.

I then checked the NVIDIA documentation, https://docs.nvidia.com/jetson/archives/r36.3/DeveloperGuide/AR/BootArchitecture/PartitionConfiguration.html?highlight=partition%20layout#partition-configuration-files, and the id= is not listed in the possible arguments for Element Tag Attributes.
So, I tried to remove the id=x for APP_a/b, and voila, it worked.

So, should the xml files be updated or ???
Basicly, where should this be reported?
Or am I missing something?