Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes #3094: continue to replace substring in HttpHeaderValueLexer #3097

Merged
merged 3 commits into from
Nov 13, 2024

Conversation

xuzhg
Copy link
Member

@xuzhg xuzhg commented Oct 24, 2024

Add the test cases for HttpUtils

Issues

This pull request fixes #3094.

Description

  • This PR focuses on HttpHeaderValueLexer, try to replace 'substring' using ReadOnlyMemory to save the memory allocatioin.
  • Add test cases for httpUtils

Checklist (Uncheck if it is not completed)

  • Test cases added
  • Build and test with one-click build and test script passed

Additional work necessary

If documentation update is needed, please add "Docs Needed" label to the issue and provide details about the required document change in the issue.

@xuzhg xuzhg merged commit be48a19 into main Nov 13, 2024
5 checks passed
@xuzhg
Copy link
Member Author

xuzhg commented Nov 13, 2024

Let me know your more concerns.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Use ReadOnlySpan<char> to replace 'new string(...)'
3 participants