Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement IAsyncDisposable in all types that implement IDisposable #3049

Open
gathogojr opened this issue Aug 30, 2024 · 0 comments
Open

Implement IAsyncDisposable in all types that implement IDisposable #3049

gathogojr opened this issue Aug 30, 2024 · 0 comments

Comments

@gathogojr
Copy link
Contributor

Implement IAsyncDisposable in all types that implement IDisposable.

Assemblies affected

Some types like ODataMessageReader implement IDisposable but not IAsyncDisposable. The currently version of the library supports .NET 8 so we should be able to implement logic for both sync and async disposal of resources.

Expected result

Ability to asynchronously dispose resources where applicable

Actual result

For some types, one is forced to call the sync Dispose method to dispose resources.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants