Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Need onArrowRelease function param for useFocusable #143

Open
yujhenchen opened this issue Sep 28, 2024 · 2 comments · May be fixed by #145
Open

Need onArrowRelease function param for useFocusable #143

yujhenchen opened this issue Sep 28, 2024 · 2 comments · May be fixed by #145
Assignees

Comments

@yujhenchen
Copy link

Hi,

Our team is currently building a Smart TV application and we find that having an onArrowRelease function parameter for the useFocusable hook would be highly beneficial, similar to the existing onEnterRelease. Since this function is not currently available and we have an urgent need for it, I would love to try to contribute by creating it myself. If it’s okay with you, I’d be happy to submit a pull request for your team to review later.

Looking forward to hearing from you. Thank you!

@predikament
Copy link
Collaborator

Hello @yujhenchen!

Thanks for getting in touch.

I'm not 100% sure I am following what exactly you need here, but if you see something missing that you'd like to propose a change for that you think could be useful then you're definitely welcome to open a PR. 👍🏻

@yujhenchen yujhenchen linked a pull request Oct 10, 2024 that will close this issue
@yujhenchen
Copy link
Author

Hi @predikament

I just created a PR and would appreciate any feedback. Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants