Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix units in diagnostic fields #37

Open
gold2718 opened this issue Aug 28, 2024 · 3 comments
Open

Fix units in diagnostic fields #37

gold2718 opened this issue Aug 28, 2024 · 3 comments
Labels
bug Something isn't working documentation Improvements or additions to documentation
Milestone

Comments

@gold2718
Copy link
Contributor

unitless is not commonly accepted as a valid unit description.

Update the addfld descriptions in oslo_aero_diagnostics to use more relevant descriptions (e.g., kg kg-1, ln(W W-1)).

@gold2718 gold2718 added bug Something isn't working documentation Improvements or additions to documentation labels Aug 28, 2024
@gold2718 gold2718 added this to the NorESM2.5 milestone Aug 28, 2024
@oyvindseland
Copy link

Is "dimensionless" better than "unitless" The meaning is the same.
And yes, for aerosol optical depth it is the correct unit, see e.g https://darktarget.gsfc.nasa.gov/basic-definitions

@gold2718
Copy link
Contributor Author

The accepted unit for this type of unitless quantity is 1. See the relevant CF Convention fields (search for "optical").

@oyvindseland
Copy link

Yes you are correct. Sorry about the confusion

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working documentation Improvements or additions to documentation
Projects
Status: Todo
Development

No branches or pull requests

2 participants