Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve the types of task arguments #5434

Open
alcuadrado opened this issue Jun 26, 2024 · 0 comments
Open

Improve the types of task arguments #5434

alcuadrado opened this issue Jun 26, 2024 · 0 comments
Assignees
Labels
v-next A Hardhat v3 development task

Comments

@alcuadrado
Copy link
Member

When creating the first few tasks we noticed that our types within actions are pretty annoying, as the task arguments are typed as Record<string, unknown>.

We could infer a mostly complete type for the task arguments doing something like this.

We would infer the types of arguments that are available in that task definition/override and use Record<string, any> for anything else. This sounds like a reasonable trade-off.

@github-actions github-actions bot added the status:ready This issue is ready to be worked on label Jun 26, 2024
@alcuadrado alcuadrado added v-next A Hardhat v3 development task and removed status:ready This issue is ready to be worked on labels Jun 27, 2024
@schaable schaable self-assigned this Jul 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
v-next A Hardhat v3 development task
Projects
Status: In Progress
Development

No branches or pull requests

2 participants