Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

does not work in wasm #1

Closed
extrawurst opened this issue Nov 27, 2023 · 6 comments
Closed

does not work in wasm #1

extrawurst opened this issue Nov 27, 2023 · 6 comments

Comments

@extrawurst
Copy link
Contributor

would be helpful if we had a feature enabling parking_lot/wasm-bindgen

see libp2p/rust-libp2p#2143
@extrawurst extrawurst mentioned this issue Nov 27, 2023
Closed
@NobodyXu
Copy link
Owner

If std::sync::Mutex works on wasm, then maybe I can add a new feature for parking_lot, making it optional?

@extrawurst
Copy link
Contributor Author

no its really just about using the right parking_lot feature flag: extrawurst/bevy_extern_events@e46f9ac

@NobodyXu NobodyXu mentioned this issue Nov 27, 2023
Merged
@NobodyXu
Copy link
Owner

I didn't find the feature "wasm-bindgen" on parking_lot https://github.com/Amanieu/parking_lot/blob/master/Cargo.toml which is strange because bevy also uses it...

@extrawurst
Copy link
Contributor Author

Ha it was removed in 0.12. so my PR might have actually fixed it 😂

see Amanieu/parking_lot@6e35524

@NobodyXu
Copy link
Owner

I will publish a new release tonight then.

@NobodyXu
Copy link
Owner

Released v0.1.2

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@extrawurst @NobodyXu