Allow a block to be passed to authenticate #704
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Finally figured out that it was the doubles in the specs that were causing them to fail, not the actual lib code. Signed-off-by: Steven Hoffman <[email protected]>
Signed-off-by: Steven Hoffman <[email protected]>
Signed-off-by: Steven Hoffman <[email protected]>
Signed-off-by: Steven Hoffman <[email protected]>
Signed-off-by: Steven Hoffman <[email protected]>
Might as well use the same response method as with tokens Signed-off-by: Steven Hoffman <[email protected]>
Signed-off-by: Steven Hoffman <[email protected]>
Signed-off-by: Steven Hoffman <[email protected]>
|
Hi @Fustrate, thanks a lot for your contribution! I've briefly read the code and it looks good (and thanks for improving specs!). I'll have more time next week to read it once again in detail and then I'll let you know if I'd change anything there. Answering your question about coding style - it would be great to improve the style. I haven't run rubocop on Sorcery code, but I know it must show lots of issues. I don't agree with some of them - e.g. I do't like enforcing single/double quotes, and I prefer to keep lines up to 100 chars instead of 80, but I'm fine with such changes as well. |
|
Any updates on this? |
Hopefully this isn't the wrong direction.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Per the discussion at #698.