Instagram Auth Changes Merged #625
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
September 7, 2014 22:23
- registered as external submodule - implemenation in providers directory added mapping to create_user functionality
- in internal app, named routes/methods for instagram - stubbed/tested changes in controller_oauth_2_spec - (note some reformatting changes, not logic changed) - in instagram provider, change logic for testing strategy Conflicts: spec/rails_app/app/controllers/sorcery_controller.rb
|
^ @arnvald eg when I say I have branches on my fork to that effect, I mean branches not-merged and having my commits independently to / without the 3 you merged in master this weekend. |
|
@arnvald as always feel free to let me know if you encounter issues |
| def build_access_scope! | ||
| valid = /\A(basic|comments|relationships|likes)$/ | ||
|
|
||
| if !access_permissions.present? |
There was a problem hiding this comment.
We can replace it with if access_permissions.blank? - it's easier to read
|
Hey folks - what's the state here? Is this something where I can help on? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
the commits are reasonably well explained but I'll stay reachable. if you prefer rebasing / cherry picking yourself (tbh my preference too), I have branches on my fork to that effect. oh yeah and it passes spec on my computer, so this is partially to verify with the help of the CI
cheers
-patrick