Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

migrate to coreforecast #311

Merged
merged 15 commits into from
Mar 4, 2024
Merged

migrate to coreforecast #311

merged 15 commits into from
Mar 4, 2024

Conversation

jmoralez
Copy link
Member

@jmoralez jmoralez commented Feb 13, 2024

Description

  • Replaces most of the numba-based computations (target transformations, grouped array functions) with coreforecast.
  • Adds the Combine and Offset lag transformations to easily extend the coreforecast-based lag transformations.
  • Updates the documentation to prefer the built-in transformations vs the numba-based ones.

Checklist:

  • This PR has a meaningful title and a clear description.
  • The tests pass.
  • All linting tasks pass.
  • The notebooks are clean.

Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

@jmoralez jmoralez changed the title set built-in lag_transforms as default migrate to coreforecast Feb 16, 2024
@jmoralez jmoralez marked this pull request as ready for review February 29, 2024 23:41
@jmoralez jmoralez merged commit eba4921 into main Mar 4, 2024
18 checks passed
@jmoralez jmoralez deleted the default-core-tfms branch March 4, 2024 17:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant