Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

support lag transforms namer #280

Merged
merged 4 commits into from
Dec 6, 2023
Merged

support lag transforms namer #280

merged 4 commits into from
Dec 6, 2023

Conversation

jmoralez
Copy link
Member

@jmoralez jmoralez commented Dec 6, 2023

Description

Adds a lag_transforms_namer argument to MLForecast which will take the lag transformations along with their lag and possible extra arguments and should return a name.

Fixes #278

Checklist:

  • This PR has a meaningful title and a clear description.
  • The tests pass.
  • All linting tasks pass.
  • The notebooks are clean.

Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

@jmoralez jmoralez changed the title support transforms namer support lag transforms namer Dec 6, 2023
@jmoralez jmoralez merged commit 6f41765 into main Dec 6, 2023
17 checks passed
@jmoralez jmoralez deleted the transforms-namer branch December 6, 2023 18:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Core] Support naming features
1 participant