Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build failure: tremor-rs #365909

Open
FliegendeWurst opened this issue Dec 17, 2024 · 2 comments · May be fixed by #366089
Open

Build failure: tremor-rs #365909

FliegendeWurst opened this issue Dec 17, 2024 · 2 comments · May be fixed by #366089
Labels
0.kind: build failure A package fails to build

Comments

@FliegendeWurst
Copy link
Member

Steps To Reproduce

  1. build tremor-rs on staging-next (didn't try master)

Build log

Build Log
error: elided lifetime has a name
    --> tremor-script/src/lexer.rs:1347:36
     |
807  | impl<'input> Lexer<'input> {
     |      ------ lifetime `'input` declared here
...
1347 |         F: Fn(Cow<'input, str>) -> Token,
     |                                    ^^^^^ this elided lifetime gets resolved as `'input`
     |
note: the lint level is defined here
    --> tremor-script/src/lib.rs:16:9
     |
16   | #![deny(warnings)]
     |         ^^^^^^^^
     = note: `#[deny(elided_named_lifetimes)]` implied by `#[deny(warnings)]`

error: elided lifetime has a name
    --> tremor-script/src/lexer.rs:1441:36
     |
807  | impl<'input> Lexer<'input> {
     |      ------ lifetime `'input` declared here
...
1441 |         F: Fn(Cow<'input, str>) -> Token,
     |                                    ^^^^^ this elided lifetime gets resolved as `'input`

error: could not compile `tremor-script` (lib) due to 2 previous errors

Additional context

Metadata

Notify maintainers

@happysalada @akshatagarwl


Note for maintainers: Please tag this issue in your PR.


Add a 👍 reaction to issues you find important.

@FliegendeWurst FliegendeWurst added the 0.kind: build failure A package fails to build label Dec 17, 2024
@FliegendeWurst
Copy link
Member Author

Probably the fix is really simple: nuke #![deny(warnings)]

@happysalada
Copy link
Contributor

Thank you for reporting. If you have time for a PR dont hesitate.

@FliegendeWurst FliegendeWurst linked a pull request Dec 18, 2024 that will close this issue
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
0.kind: build failure A package fails to build
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants