Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dontCheck for haskell packages doesn't remove dependencies #224197

Open
MangoIV opened this issue Apr 1, 2023 · 3 comments
Open

dontCheck for haskell packages doesn't remove dependencies #224197

MangoIV opened this issue Apr 1, 2023 · 3 comments
Labels

Comments

@MangoIV
Copy link
Contributor

MangoIV commented Apr 1, 2023

Describe the bug

using dontCheck doesn't remove the need for dependencies

Steps To Reproduce

Steps to reproduce the behavior:

nix build github:jfaure/irie-lang/4aac3edc221e8309396c8a547adfab20f3e961f7

Expected behavior

dontCheck removes the need for depending on fused-effects as it is only a dependency for the testsuite https://github.com/jfaure/Irie-lang/blob/4aac3edc221e8309396c8a547adfab20f3e961f7/flake.nix#L27

Additional context

  • callHackage is used
@MangoIV MangoIV added the 0.kind: bug Something is broken label Apr 1, 2023
@maralorn
Copy link
Member

maralorn commented Apr 1, 2023

This is more or less an implementation detail of how we use callPackage. The function expects a fused-effects argument, and if that is not in scope it fails. I would appreciate a fix for that but I don‘t know of one (at least not without butchering debugging).

Nevertheless fused-effects is only expected as a function argument. It will never be used in the function if you use dontCheck and fused-effects is only used in the test. That means you can fix your build by passing fused-effects = null.

@MangoIV
Copy link
Contributor Author

MangoIV commented Apr 1, 2023

Thank you. This is pretty much what I expected.

@sternenseemann
Copy link
Member

Related: NixOS/cabal2nix#531 NixOS/cabal2nix#593

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

4 participants