Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

nixpkgs-vet wants to move packages with uppercase names to pkgs/by-name #133

Closed
pluiedev opened this issue Dec 4, 2024 · 2 comments
Closed

Comments

@pluiedev
Copy link

pluiedev commented Dec 4, 2024

Ditto (see https://github.com/NixOS/nixpkgs/actions/runs/12161429913/job/33916017215)

This issue is sort of similar to #107 and we really need to be more careful and only select packages that fit the naming criteria outlined by RFC 140:

Check the following using CI:

  • pkgs/by-name must only contain subdirectories of the form ${shard}/${name}, called package directories.
  • The name's of package directories must be unique when lowercased
  • name is a string only consisting of the ASCII characters a-z, A-Z, 0-9, - or _.
  • shard is the lowercased first two letters of name, expressed in Nix: shard = toLower (substring 0 2 name).
  • Each package directory must contain a package.nix file and may contain arbitrary other files.
@pluiedev
Copy link
Author

pluiedev commented Dec 4, 2024

NVM, I misread the RFC 😓

@pluiedev pluiedev closed this as not planned Won't fix, can't repro, duplicate, stale Dec 4, 2024
@infinisil
Copy link
Member

infinisil commented Dec 4, 2024

Not sure I get what you mean, can you be more specific?

Edit: Ahh, only saw it being closed after I posted this :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants