-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Lock Screen Notification Text Color Inverted in Dark Mode #3641
Comments
You mention target sdk level 29, do you know about 25, 26, 27, 28 ? The reason I ask is that we would plan to incrementally advance targetsdk levels because there are associated issues with each level - some of which we may not be able to overcome. So if this problem doesn't exist on the next target sdk level than that would be a convenient fix compared to anything more drastic. |
I just tested API level 25-28 and they all show the issue. I then compiled with 29 and the issue went away. I'm using an emulator in Android Studio running Android 14. I will re-try with an emulator running Android 15. To be clear, the only line I'm modifying between builds is the following: Line 95 in 5345dd5
|
Ok thanks, that is useful but changing targetSdk level to 29 is a gigantic change in terms of app behavior so I am hoping to find a resolution which doesn't involve doing that. |
I agree. When we retired Android 6 a few months ago, there were complaints even though Android 6 is really old. If we change the target to 29, we will be retiring 7, 8 and 9. If we do that now, we will be denying access to xDrip to a significant population worldwide. It is too soon for that now. |
I don't know if that's entirely true. Changing the targetsdk is not the same as changing the minsdk.
|
I see. Thanks for correcting me. |
I also just tried API 28 on an emulator running the latest image of Android 15 and the issue is still there. |
The most significant thing about changing the targetSdk level is that it opts the app in to new behaviors and restrictions. |
If we had a fully functional alpha channel, many would be using it and the Nightly channel would then be what it in my opinion should really be to test things like this. We could then release a Nightly going forward one step changing the target sdk and I would announce its purpose. Having all of that knowledge, we could then decide if we should really switch the target to 29 or not now. In the meantime, those who like to have more updates than only twice a year could use the alpha channel. I am happy to maintain the alpha channel. |
Subject of the issue
Link to the discussion thread: #3617
Every time a new reading comes in with the screen off and you turn the screen on, the xDrip ongoing notification colors are inverted.
Your environment
Expected behavior
In dark mode, text should be white on the xDrip notifications at all times.
Actual behavior
Untitled-1.mp4
It has to do with the specific color you set in the Android theme settings. I had mine set to blue, and with that setting when setting the target sdk to 24 it causes the bug. sdk 23 or 29 don't have it. I was able to reproduce on an emulator as seen in the video. The bug is weird though since as you can see in the video, if you go past the lock screen and pull down the notification once, then it fixes the color. It stays correct until the notification refreshes after 5 minutes (when the next glucose reading comes in).
Steps to reproduce the behavior:
See video above.
The text was updated successfully, but these errors were encountered: