Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Better support for HEIC files #26

Open
PoeHaH opened this issue Nov 24, 2024 · 0 comments
Open

Better support for HEIC files #26

PoeHaH opened this issue Nov 24, 2024 · 0 comments

Comments

@PoeHaH
Copy link

PoeHaH commented Nov 24, 2024

First of all: thank you for maintaining this! Not sure what happened to the original Dropzone but it's widely used so I'm happy to see interest in further keeping this alive :-).

Images taken with iPhone cameras are often stored in a raw format with ".heic" extension. Their mime type is "image/heic" so Dropzone tries to render a thumbnail preview, but it doesn't work:
image

In the source code, we can see why the thumbnail can't be displayed:
image

In short, the dataUrl is not a string, but an object.

I propose to fix this by making a simple change to the thumbnail() function to check if the dataUrl is a string.
image

Would you be open to add this into the next release?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant