Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wrong version number for version attribute of NWB file in NWB Schema version 2.2.0 #589

Open
ehennestad opened this issue Sep 12, 2024 · 2 comments
Assignees
Labels
category: bug errors in the code or code behavior category: question questions about code or code behavior priority: medium non-critical problem and/or affecting only a small set of NWB users

Comments

@ehennestad
Copy link

ehennestad commented Sep 12, 2024

For the version 2.2.0 release of the nwb-schema the file version attribute in nwb.file.yaml is 2.1.0.

This is outdated now, but I am suspecting it is contributing to a whole class of different error messages when trying to open NWB Files in matnwb using nwbRead where the file is created with v2.2.0 but the nwb file version attribute is set to 2.1.0 due to this error in the schema.

I did a quick search in issues, but could not find any mention of this. Is this a known issue? If yes, please point me to discussions regarding this. If no, is there anything that can be done at this time?

As the hdmf_common namespace was introduced with v2.2.0 this is potentially a critical bug for nwb files created in matnwb using v2.2.0.

Edit: Assuming the correct versions of the schemas are embedded in the file, I don't think the above statement is correct.

value: 2.1.0

@stephprince
Copy link
Contributor

Thanks for the issue @ehennestad.

@rly It looks like you had fixed the version mismatch previously, do you remember if there was any discussion about this or could you advise?

@stephprince stephprince added category: bug errors in the code or code behavior priority: medium non-critical problem and/or affecting only a small set of NWB users category: question questions about code or code behavior labels Sep 12, 2024
@ehennestad
Copy link
Author

Great, I see that this was fixed by bumping version up to 2.2.1 ~1week later, so maybe this was not really exposed to users for a long time

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
category: bug errors in the code or code behavior category: question questions about code or code behavior priority: medium non-critical problem and/or affecting only a small set of NWB users
Projects
None yet
Development

No branches or pull requests

3 participants