-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Cannot extend OptogeneticSeries
to have 2D data
#556
Comments
I believe this is because the OptogeneticSeries restricts the shape of Lines 6 to 11 in ec0a879
Similar to classes in programming, child-classes can restrict properties or can add new properties but child classes cannot relax properties. E.g., if you parent class is If you want to build of that says a car must have 4 wheels then a child class, e.g., RaceCar, cannot then change this to |
Thank you for the clarification, I understand now. @alessandratrapani what do you think about this? |
Thank you so much for the explanation @oruebel. It's true that the holographic stimulus could be seen as a type of optogenetic stimulus. Still, they are also very different concepts in the way they deliver light to the sample: by constraining optogenetic series being one dimension I guess they were referring only to widefield optogenetic stimulation (single photon excitation), but you could have patterned photostimulation (that usually uses two-photon excitation) that needs a second dimension to be described since they target single ROI. |
Updating |
I'd prefer to extend |
I think relaxing |
I agree. I think relaxing Is this still needed in light of the new path forward with |
If we move forward with the TimeInterval approach, we will not extend from OptogeneticSeries anymore. But maybe it is worth to leave the option open. |
@alessandratrapani is working on an extension for holographic stimulation data. We would like to extend
OptogeneticSeries
to have 2D data (n_time x n_roi), however we got "incorrect shape" (see below) after changing "data" to allow for 2D.Original issue opened here
The text was updated successfully, but these errors were encountered: