Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

clarify instructions suggesting existing delay #26

Open
ElliotMebane opened this issue Apr 5, 2019 · 1 comment
Open

clarify instructions suggesting existing delay #26

ElliotMebane opened this issue Apr 5, 2019 · 1 comment

Comments

@ElliotMebane
Copy link

https://github.com/NeuroTechX/bci-workshop/blob/master/INSTRUCTIONS.md

instructions say:
...
Then, add the following to line 191 of bgapi.py and save:

time.sleep(.25)

Please clarify what the correct code snippet should be. I already have that sleep code on line 187 so I'm not sure if my code already had the fix applied. Also including it at 191 seems fine so I'll add it anyway.

@micuat
Copy link
Collaborator

micuat commented Apr 25, 2019

I guess pygatt has been updated and the instruction is obsolete. I don't have a device to test but I will make a pull request anyways, so hopefully someone will pick this up and merge it @hubertjb @rcassani @jdpigeon

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants