-
Notifications
You must be signed in to change notification settings - Fork 756
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix FFmpeg configuration issue for adding library privates of gcc and clang in meson build file #1178
base: master
Are you sure you want to change the base?
Conversation
More context is needed. Can you please describe the "FFmpeg configuration issue"? |
Hi, @kylophone! I can describe about FFmpeg configuration issue. When I finished compiling libvmaf and installed my prefix folder, then I head to FFmpeg to type command example like
The solution is I added -lstc++ in libvmaf/src/meson.build to fix FFmpeg configuration problem, so the FFmpeg can detect libvmaf operation well using additional command of Some peoples were having issue to compile FFmpeg with libvmaf static library, the issue is there: If you have any question or issues, please feel reply to me.
|
A note of two things:
|
@1480c1, yeah you're probably right. I just tried with libc++ command in my GCC compiler and won't work. libc++ is the only can work for clang compiler and the gcc is libstdc++. I was wondering, if we can detect two compilers of GCC and Clang in meson.build, let's just say... If compiler is GCC, it should go -lstdc++ with pre-pkgconfig. If compiler is clang, it should go -lc++ with pre-pkgconfig.
|
It is technically possible to use libc++ and g++ as noted in llvm's page g++ -nostdinc++ -nodefaultlibs \
-isystem <install>/include/c++/v1 \
-L <install>/lib \
-Wl,-rpath,<install>/lib \
-lc++ -lc++abi -lm -lc -lgcc_s -lgcc \
test.cpp But it looks impossibly hard, so I think at least g++ == libstdc++ is a good assumption to start with. You could try checking if the cxx_link_args variable contains the strings I mentioned. That's the best I got for now until I wake up in the morning. |
6726b03
to
35566ed
Compare
Please check my new commit. Thank you. :)
|
This will add libraries_private in libvmaf/src/meson.build to fix FFmpeg configuration issue.
This will add libraries_private in libvmaf/src/meson.build to fix FFmpeg configuration issue.
I checked with FFmpeg configuration after -lstdc++ is added to libs.private in pkgconfig with ninja install and works well.