-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[BUG] Vision modes are sometimes broken on linux #438
Comments
EDIT: Debug build's also affected, so not debug vs release issue |
how are you sure that debug mode is 100% unaffected? it wasnt happening 100% of the time on release linux (atleast on my machine), found a way to reproduce? |
From some limited empirical testing on my own machine, this seems to fix it at least for me:
I don't know why this happens or if this is a universal fix, but I can't reproduce the bug anymore after following these steps. I'm guessing it might have something to do with whatever state is being cached here somehow getting corrupted over multiple restarts of the game. Would be curious to hear if this works for others using Linux. |
@Rainyan Seems like that works. It seems the cache is rather inconsistent/varied anyway (some having like 3 items, some like 50). It seems to me that file can just be this:
And read-only and it seems to also just work out due to no cache? It also looks like it generates at the end, maybe it could be programatically worked-around by being early (or late) enough to delete/overwrite that file as a potentional work around to not need read-only. Although just a guess. |
I quickly tried this in Another thing maybe worth testing would be to simply programmatically rewrite the file contents to the dummy contents you posted above at
|
Fix NeotokyoRebuild#438 This is a hack around the vision mode shaders sporadically breaking on Linux builds. It seems that for whatever reason, the shader state cached here gets corrupted somehow upon successive runs of the game, and write-protecting the file offers a simple way to avoid that corruption. For more discussion, see: NeotokyoRebuild#438 (comment)
Fix NeotokyoRebuild#438 This is a hack around the vision mode shaders sporadically breaking on Linux builds. It seems that for whatever reason, the shader state cached at the glshaders file somehow leads to the corruption upon successive runs of the game, and write-protecting the file offers a simple way to avoid that breakage. Ideally, we should figure out what's really going wrong here at the shader system and/or precaching level, but this should suffice for avoiding the bug. We're doing this at runtime because we can't version control the filesystem specific file metadata required for the read-only state. For more discussion, see: * NeotokyoRebuild#587 * NeotokyoRebuild#438 (comment)
Build Info
20240629_321f139
Description
Sometimes, the vision modes shaders are broken on linux and they're either completely black, or the colors are all wack.
To Reproduce
Unreproducible
Expected behavior
Normal vision modes
Actual behavior
Broken vision modes
Operating System
Version/Distro
Arch
Machine's CPU
No response
Machine's GPU
No response
GPU's driver
No response
Build's compiler
No response
Additional context and Screenshots
Needs screenshots, but @nullsystem had the same problem as well
The text was updated successfully, but these errors were encountered: